Do not auto-approve dependabot PRs, and add cooldown to dependabot#1564
Open
ludfjig wants to merge 1 commit into
Open
Do not auto-approve dependabot PRs, and add cooldown to dependabot#1564ludfjig wants to merge 1 commit into
ludfjig wants to merge 1 commit into
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
ludfjig
added
area/security
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the repository automation that auto-approved/auto-merged Dependabot PRs (to require human review) and adds a Dependabot “cooldown” period to reduce update churn while still allowing Dependabot to operate normally.
Changes:
- Deleted the scheduled GitHub Actions workflow that auto-approved/auto-merged Dependabot PRs.
- Removed the
dev/auto-approve-dependabot.shscript used by that workflow. - Added a 7-day Dependabot cooldown across configured ecosystems/directories.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dev/auto-approve-dependabot.sh |
Removed the Dependabot auto-approval/auto-merge script to require human review. |
.github/workflows/auto-merge-dependabot.yml |
Removed the scheduled workflow that used the script to auto-approve/auto-merge Dependabot PRs. |
.github/workflows/dep_update_guest_locks.yml |
Removed a comment referencing the deleted auto-merge workflow (no functional change). |
.github/dependabot.yml |
Added cooldown: default-days: 7 to reduce update noise and avoid immediate adoption of freshly-released versions. |
jsturtevant
reviewed
Jun 19, 2026
jsturtevant
left a comment
jsturtevant
left a comment
Contributor
There was a problem hiding this comment.
It seems this is a wise choice in the current environment, but it will make a little bit more work for maintainers. I would leave it for others to look at too and give some comments or approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically merging PRs is not a good idea security-wise, especially given the many supply chain attacks these days. Having a human review the diff of an updated crate is always good to make sure it's not been compromised. This PR removes auto-approving PRs by our bot and also adds a cooldown to dependabot which is good practice in general.
I also considered just adding a dependabot cooldown, and also only auto-merging patch/minor bumps, but ultimately settle on this which I think is the better approach.
Note: The bot is still used in
dep_update_guest_locks.yml